Skip to content

leol - Technical Training #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: 18.0
Choose a base branch
from
Open

leol - Technical Training #724

wants to merge 17 commits into from

Conversation

leclerc-leo
Copy link 

  U  ___ u   ____       U  ___ u    U  ___ u 
    \/"_ \/  |  _"\       \/"_ \/     \/"_ \/ 
    | | | | /| | | |      | | | |     | | | | 
.-,_| |_| | U| |_| |\ .-,_| |_| | .-,_| |_| | 
 \_)-\___/   |____/ u  \_)-\___/   \_)-\___/  
      \\      |||_          \\          \\    
     (__)    (__)_)        (__)        (__)

@robodoo
Copy link

robodoo commented Apr 22, 2025

Pull request status dashboard

naja628
naja628 reviewed Apr 23, 2025
View reviewed changes
Copy link

@naja628 naja628 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi -- Great work :)

I left some nitpicks but nothing substantial to say aside from the compute dependency
(reviewed up to ch 8)

naja628
naja628 reviewed Apr 23, 2025
View reviewed changes
@naja628
Copy link

naja628 commented Apr 24, 2025

@vava-odoo I'll let you take over for the 2nd review :)

vava-odoo
vava-odoo reviewed Apr 28, 2025
View reviewed changes
Copy link

@vava-odoo vava-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please come to me if anything is unclear.

@leclerc-leo leclerc-leo force-pushed the 18.0-training-leol branch from 24f639f to 8edaa13 Compare May 2, 2025 15:11
naja628
naja628 reviewed May 5, 2025
View reviewed changes
Copy link

@naja628 naja628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello :) -- great work !
I left a few comments on the js

@leclerc-leo leclerc-leo force-pushed the 18.0-training-leol branch from 8edaa13 to 001dce8 Compare May 5, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naja628 naja628 naja628 left review comments

@vava-odoo vava-odoo vava-odoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leclerc-leo @robodoo @naja628 @vava-odoo